Remove rust, and add nix flake by Pablu23 · Pull Request #951 · fkie-cad/Logprep

Pablu23 · 2026-03-31T14:14:18Z

Description

Remove unused rust dependencies, remove setuptools_scm and use uv_build, add nix flake for container image, dev shell and application building

Assignee

The changes adhere to the contribution guidelines
I have performed a self-review of my code
My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

README.md is up-to-date
CHANGELOG.md is up-to-date
Documentation (doc/source) is up-to-date
Preview for docs looks fine
Notebooks are up-to-date and functional
Examples are up-to-date and functional (including compose & k8s)

Code Quality

Patch test coverage > 95% and does not decrease
New code uses correct & specific type hints

How did you verify that the changes work in practice?

nix develop
nix build .#docker.python311 && docker load < result && docker run logprep:py3.11

Reviewer

The code is readable/maintainable and follows the contribution guidelines
Documentation is up-to-date
Tests (unit & acceptance) are meaningful and not over-mocked

The rendered docs for this PR can be found here.

codecov-commenter · 2026-03-31T14:24:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (0fc524b) to head (e7228ba).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         218      218           
  Lines       14373    14373           
=======================================
  Hits        13828    13828           
  Misses        545      545

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…r and smaller

…NCH env, set names to human typable names

… pyproject.toml, update flake.nix

…downloaded aswell

…age, update check examples to pre built correct version

…ix shell dependencies

mhoff

Many thanks for the work! I did a first review pass

mhoff · 2026-04-17T11:57:55Z

@@ -0,0 +1 @@
+use flake


This is only required for nix build, right? I am a bit hesitant to add this new file solely for builds and I would assume that it would also be loaded for all other operations (like running logprep etc.)

this is for direnv, if you have direnv installed and allow the directory, it auto loads the nix flake. I definitly need it, I previously did not commit it, but I have seen it on nearly every big open source project, so I thought it would be best practice to commit aswell. This by itself does nothing

mhoff · 2026-04-17T11:58:04Z

        with:
          version: latest
+      - name: Set up Nix
+        uses: cachix/install-nix-action@v31


Commit SHA. I assume you did not do this as the PR is not finalized yet, but I still wanted to add the comment as a reminder not to forget for future reviews

mhoff · 2026-04-17T11:59:39Z

      - name: Run Compose setup
        working-directory: examples/compose
-        run: docker compose up -d
+        run: PYTHON_VERSION="${{ matrix.python-version }}" docker compose up -d


This was a bug right? ... nice catch

Yeah it probably was, I think before we actually always just used py3.11 for the checks it seems. I just changed this, because there now is no image called logprep:py3.11 when running in py3.12 matrix as we dont build it directly in the docker file

mhoff · 2026-04-17T12:02:34Z

        working-directory: examples/compose
-        run: docker compose build --build-arg PYTHON_VERSION=${{ matrix.python-version }}
+        run: |
+          export PY_VERSION="${{ matrix.python-version }}"


Why not use the same wording as below (PYTHON_VERSION)? Does nix build use PY_VERSION internally? If not, let's simply use PYTHON_VERSION and put in under env together with COMPOSE_PROFILES. This way (as we are reusing compose-env in "Run Compose setup" we have it all in one go.

This has to do with the nameing of the docker file, .#docker.python311 is the current name for building 3.11, using .#docker.3.11 would then be something different as .#docker.311, thats why we export it as a variable and then do some Bash magic on it to transform 3.11 to python311, without the dot

Ahh no now I get what you mean, yeah ill change that. I was a little confused

mhoff · 2026-04-17T12:09:47Z

 * install requirements with `uv sync --frozen --extra doc` in project root
+
+## nix version
+* nix develop


I don't get what this means. Maybe still a placeholder. Needs more context because people are typically not familiar with nix

Edit: installation.rst makes it more clear, but still

…ntainer version scheme, delete unused Dockerfile

Co-authored-by: Michael Hoff <9436725+mhoff@users.noreply.github.com>

Pablu23 added 2 commits March 31, 2026 16:13

Remove rust, add flake nix for dev and compile, no docker build for now

4b428d6

Remove rust testing from github workflows

e7228ba

Pablu23 and others added 27 commits March 31, 2026 16:45

First try docker image from nix

0174e5a

Use buildLayeredImage instead of buildImage, as it is cache friendlie…

933706b

…r and smaller

Update flake nix to accomodate all python versions we support

9cbf466

Add pretend version basic

f0c579e

Make envs available under .#python311 and not .#envs.python311

e3b3125

Add version with VERSION env, add branch name for docker tag with BRA…

dad2005

…NCH env, set names to human typable names

Merge branch 'main' into feat-nix

1ff6014

Update uv.lock use uv_build instead of setuptools_scm, set version in…

5e9900b

… pyproject.toml, update flake.nix

Remove version from flake.nix

34b1fac

Update container build workflow, and remove unused self from nix flake

d873463

Update to use show current instead of abbref ref

a2a62db

remove closing bracket

19310a1

update to use github_ref

b8987f0

Debug

b7876cf

Debug

d78b607

Update to use GITHUB_HEAD_REF

775a74f

DEBUG

d203aa0

Add tagging

3ce7c05

Add py to image tag

9cae1bf

Try to force packages.x86_64 so no extra content like gpu stuff gets …

cdb5511

…downloaded aswell

Inspect docker image

2c5d0a3

Downgrade version to 19.0.0 again, because 19.0.0 is last released

5134c5c

Add docker image push

ecae169

debug

c5a7343

debug

4f6d853

debug

70d109f

test with cosign and trivy

8199fef

Pablu23 added 5 commits April 17, 2026 08:59

Update uv.lock

124c3f2

Add non root user to docker image, update compose to use pre built im…

54c170e

…age, update check examples to pre built correct version

Remove uv version, and add comment, also add nix setup

ebb6482

Set PY_VER from matrix.python-version

8375bcd

Run specific version of python in docker compose

77966a0

Pablu23 marked this pull request as ready for review April 17, 2026 10:46

Pablu23 requested a review from mhoff April 17, 2026 10:46

Update CHANGELOG.md and add simple doc for nix, add pandoc to flake.n…

a36e887

…ix shell dependencies

mhoff requested changes Apr 17, 2026

View reviewed changes

Pablu23 and others added 5 commits April 17, 2026 12:23

rename PY_VERSION to PYTHON_VERSION, add comment for explaining in co…

3bcfbea

…ntainer version scheme, delete unused Dockerfile

Update Digest to digest

e7089b1

Change name to PYTHON_VERSION

c64a479

Update pyproject.toml

65dbb15

Co-authored-by: Michael Hoff <9436725+mhoff@users.noreply.github.com>

Update CHANGELOG.md

94c5e71

Co-authored-by: Michael Hoff <9436725+mhoff@users.noreply.github.com>

Conversation

Pablu23 commented Mar 31, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Assignee

Documentation

Code Quality

How did you verify that the changes work in practice?

Reviewer

Uh oh!

codecov-commenter commented Mar 31, 2026

Codecov Report

Uh oh!

mhoff left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pablu23 commented Mar 31, 2026 •

edited by github-actions bot

Loading